Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker ignore to ignore vendor dir #354

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Add docker ignore to ignore vendor dir #354

merged 1 commit into from
Aug 24, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Add docker ignore to ignore vendor dir. This reduces the amount of date required to send context to docker daemon.

Before the change:

$ make image
docker build -t amazon/aws-ebs-csi-driver:latest .
Sending build context to Docker daemon  121.4MB
Step 1/8 : FROM golang:1.12.7-stretch as builder
 ---> f50db16df5da
Step 2/8 : WORKDIR /go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver
 ---> Using cache
 ---> 05f9699518bd

After the change:

$ make image
docker build -t amazon/aws-ebs-csi-driver:latest .
Sending build context to Docker daemon  74.08MB
Step 1/8 : FROM golang:1.12.7-stretch as builder
 ---> f50db16df5da
Step 2/8 : WORKDIR /go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver
 ---> Using cache
 ---> 05f9699518bd
Step 3/8 : ADD . .
 ---> Using cache
 ---> a14314a2cbb1
Step 4/8 : RUN make

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 779

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.1%
Totals Coverage Status
Change from base Build 769: 0.0%
Covered Lines: 1176
Relevant Lines: 1654
💛 - Coveralls

@leakingtapan leakingtapan merged commit 14cbd79 into kubernetes-sigs:master Aug 24, 2019
@leakingtapan leakingtapan deleted the dockerignore branch August 24, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leakingtapan @k8s-ci-robot @coveralls